From 8791f8574b3631fdf79830dbde85ad517bef6fee Mon Sep 17 00:00:00 2001
From: gl0w <gl0w@world>
Date: Thu, 10 Sep 2026 06:51:07 +0100
Subject: [PATCH] m6/submit-buttons: + links on issues/pulls + form intros (118
 tests)

---
 src/forge.rs     | 64 ++++++++++++++++++++++++++++++++++++++++++++++--
 src/inbox.rs     | 48 +++++++++++++++++++++++++++++++++---
 static/style.css |  8 ++++++
 3 files changed, 115 insertions(+), 5 deletions(-)

diff --git a/src/forge.rs b/src/forge.rs
index 61a34a7..951136b 100644
--- a/src/forge.rs
+++ b/src/forge.rs
@@ -948,8 +948,9 @@ fn render_issues_index(
     description: Option<&str>,
 ) -> Result<String, String> {
     let mut body = String::from("<h1>Issues</h1>\n");
+    body.push_str("<p><a class=\"btn-new\" href=\"/new-issue.html\">+ New issue</a></p>\n");
     if data.issues.is_empty() {
-        body.push_str("<p class=\"muted\">No issues yet.</p>\n");
+        body.push_str("<p class=\"muted\">No issues yet. <a href=\"/new-issue.html\">Suggest one</a> — no account needed.</p>\n");
     } else {
         body.push_str("<div class=\"table-scroll\"><table>\n<thead><tr><th>#</th><th>title</th><th>state</th><th>comments</th><th>created</th></tr></thead>\n<tbody>\n");
         for issue in &data.issues {
@@ -994,8 +995,9 @@ fn render_issues_index(
 
 fn render_pulls_index(prs: &[Pr], site_name: &str, nav: &str, description: Option<&str>) -> String {
     let mut body = String::from("<h1>Pulls</h1>\n");
+    body.push_str("<p><a class=\"btn-new\" href=\"/new-pr.html\">+ New PR prompt</a></p>\n");
     if prs.is_empty() {
-        body.push_str("<p class=\"muted\">No pull requests yet.</p>\n");
+        body.push_str("<p class=\"muted\">No pull requests yet. <a href=\"/new-pr.html\">Suggest one</a> — no account needed.</p>\n");
     } else {
         body.push_str("<div class=\"table-scroll\"><table>\n<thead><tr><th>#</th><th>title</th><th>state</th><th>head→base</th><th>created</th></tr></thead>\n<tbody>\n");
         for pr in prs {
@@ -1391,6 +1393,64 @@ mod tests {
         }
     }
 
+    /// f0rge #25: index pages carry prominent `+` submit buttons (correct
+    /// hrefs, icon + words) and the empty states link to the forms.
+    #[test]
+    fn submit_buttons_on_issues_pulls_indexes() {
+        // Empty forge: buttons + linked empty states.
+        let repo = mktemp("submit-empty");
+        let out = mktemp("submit-empty-out");
+        render_loaded(&load(&repo), &out, "test", "<nav>", None).expect("render");
+        let issues = std::fs::read_to_string(out.join("issues/index.html")).expect("issues");
+        let pulls = std::fs::read_to_string(out.join("pulls/index.html")).expect("pulls");
+        assert!(
+            issues.contains("<a class=\"btn-new\" href=\"/new-issue.html\">+ New issue</a>"),
+            "issues + button"
+        );
+        assert!(
+            pulls.contains("<a class=\"btn-new\" href=\"/new-pr.html\">+ New PR prompt</a>"),
+            "pulls + button"
+        );
+        assert!(
+            issues.contains("No issues yet.")
+                && issues.contains("href=\"/new-issue.html\">Suggest one"),
+            "issues empty state links to form"
+        );
+        assert!(
+            pulls.contains("No pull requests yet.")
+                && pulls.contains("href=\"/new-pr.html\">Suggest one"),
+            "pulls empty state links to form"
+        );
+        // Non-empty forge: buttons stay above the tables.
+        write_forge(
+            &repo,
+            "issues/aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa/issue.md",
+            "---\nid: aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa\ntitle: T\nstate: open\ncreated: 2026-09-10T03:00:00Z\n---\nbody\n",
+        );
+        write_forge(
+            &repo,
+            "prs/bbbbbbbb-bbbb-bbbb-bbbb-bbbbbbbbbbbb/pr.md",
+            "---\nid: bbbbbbbb-bbbb-bbbb-bbbb-bbbbbbbbbbbb\ntitle: P\nstate: open\nbase: main\nhead: fix\ncreated: 2026-09-10T03:00:00Z\n---\ndesc\n",
+        );
+        let out2 = mktemp("submit-full-out");
+        render_loaded(&load(&repo), &out2, "test", "<nav>", None).expect("render");
+        let issues2 = std::fs::read_to_string(out2.join("issues/index.html")).expect("issues");
+        let pulls2 = std::fs::read_to_string(out2.join("pulls/index.html")).expect("pulls");
+        assert!(
+            issues2.contains("href=\"/new-issue.html\">+ New issue"),
+            "issues + button with rows"
+        );
+        assert!(
+            pulls2.contains("href=\"/new-pr.html\">+ New PR prompt"),
+            "pulls + button with rows"
+        );
+        assert!(
+            issues2.contains("table-scroll"),
+            "issues table still renders"
+        );
+        assert!(pulls2.contains("table-scroll"), "pulls table still renders");
+    }
+
     #[test]
     fn verdict_badge_shapes() {
         assert!(verdict_badge("pass").contains("badge pass"));
diff --git a/src/inbox.rs b/src/inbox.rs
index 4998fb0..9806475 100644
--- a/src/inbox.rs
+++ b/src/inbox.rs
@@ -593,7 +593,7 @@ pub fn store_submission(
 // ---- forms (built into dist, zero JS) ----------------------------------
 
 fn license_block() -> String {
-    let mut out = String::from("<blockquote><p>");
+    let mut out = String::from("<blockquote id=\"license-full\"><p>");
     let lines: Vec<&str> = LICENSE_TEXT.split('\n').collect();
     for (i, line) in lines.iter().enumerate() {
         if i > 0 {
@@ -618,6 +618,9 @@ fn form_page(
 ) -> String {
     let body = format!(
         "<h1>{heading}</h1>\n<p>{intro}</p>\n\
+         <p>What happens: your text goes to a private inbox only the maintainer reads — \
+         never published on this site. No account needed. The server answers a one-time \
+         ack id and shows nothing back.</p>\n\
          <form method=\"post\" action=\"{action}\">\n\
          <p><label for=\"f-title\">Title (required, up to 300 chars)</label><br>\n\
          <input type=\"text\" id=\"f-title\" name=\"title\" maxlength=\"300\" required size=\"60\"></p>\n\
@@ -631,6 +634,9 @@ fn form_page(
          <p><label>Leave this empty: <input type=\"text\" name=\"website\" value=\"\" autocomplete=\"off\" tabindex=\"-1\"></label></p>\n\
          </div>\n\
          {license}\
+         <p>In plain words: you hand your text over completely — the project can keep, share, \
+         or change it for any purpose, and you keep no rights and are owed nothing. \
+         See the <a href=\"#license-full\">full grant text</a> above.</p>\n\
          <p><label><input type=\"checkbox\" name=\"license\" value=\"agree\" required> \
          I agree to the grant above (required — unchecked submissions are rejected).</label></p>\n\
          <p><button type=\"submit\">Submit</button></p>\n\
@@ -663,7 +669,7 @@ pub fn render_forms(
         site_name,
         nav,
         "Suggest an issue",
-        "Detailed actionable text from your user. Free textbox on purpose — say what a maintainer can act on.",
+        "Spotted something worth fixing? Write it up here in plain words — say what a maintainer can act on.",
         InboxType::Issue.route(),
         "body",
         "Body",
@@ -673,7 +679,7 @@ pub fn render_forms(
         site_name,
         nav,
         "Suggest a change",
-        "ONE prompt, plain text. No files, no diff, no branch. Code words inside stay text — never applied, never executed.",
+        "Have an idea for a fix? Send ONE prompt as plain text — no files, no diff, no branch. Code words inside stay text: never applied, never executed.",
         InboxType::PrPrompt.route(),
         "prompt",
         "Prompt",
@@ -1050,4 +1056,40 @@ mod tests {
         }
         std::fs::remove_dir_all(&dir).ok();
     }
+
+    /// f0rge #25: submission pages explain the deal in human words
+    /// (private inbox, ack id, no account) plus a plain license summary
+    /// linking to the full grant text — with the full checkbox kept.
+    #[test]
+    fn forms_explain_deal_and_summarize_license() {
+        let dir = std::env::temp_dir().join(format!(
+            "hu13-inbox-forms-deal-{}-{}",
+            std::process::id(),
+            std::time::SystemTime::now()
+                .duration_since(std::time::UNIX_EPOCH)
+                .map(|d| d.as_nanos())
+                .unwrap_or(0)
+        ));
+        std::fs::create_dir_all(&dir).unwrap();
+        render_forms(&dir, "test", "", None).unwrap();
+        let issue = std::fs::read_to_string(dir.join("new-issue.html")).unwrap();
+        let pr = std::fs::read_to_string(dir.join("new-pr.html")).unwrap();
+        for html in [&issue, &pr] {
+            assert!(html.contains("private inbox"), "private suggestion");
+            assert!(html.contains("ack id"), "ack id explained");
+            assert!(html.contains("No account needed"), "no account needed");
+            assert!(html.contains("In plain words:"), "license summary");
+            assert!(
+                html.contains("href=\"#license-full\""),
+                "summary links to full text"
+            );
+            assert!(html.contains("id=\"license-full\""), "full text anchor");
+            assert!(html.contains("name=\"license\""), "checkbox kept");
+            assert!(
+                html.contains("irrevocably give it to this project"),
+                "full grant text kept"
+            );
+        }
+        std::fs::remove_dir_all(&dir).ok();
+    }
 }
diff --git a/static/style.css b/static/style.css
index 32f05a8..11a2346 100644
--- a/static/style.css
+++ b/static/style.css
@@ -59,6 +59,14 @@ button,input[type=submit]{display:inline-flex;align-items:center;justify-content
   min-height:40px;min-width:40px;background:#7aa2f7;color:#16161e;border:1px solid #7aa2f7;
   padding:.5rem 1rem;font:inherit;font-weight:700;cursor:pointer}
 button:hover,input[type=submit]:hover{background:#7dcfff}
+/* Submit buttons (m6/submit-buttons, f0rge #25): link styled as a
+   button — Tokyo Night accent fill, >=40px touch target, icon + words. */
+.btn-new{display:inline-flex;align-items:center;justify-content:center;
+  min-height:40px;min-width:40px;background:#7aa2f7;color:#16161e;
+  border:1px solid #7aa2f7;padding:.5rem 1rem;font:inherit;font-weight:700;
+  text-decoration:none;cursor:pointer}
+.btn-new:visited{color:#16161e}
+.btn-new:hover,.btn-new:focus{background:#7dcfff;text-decoration:none}
 .muted{color:#565f89}
 .badge{display:inline-block;border:1px solid #292e42;padding:.1em .5em;font-size:.85em}
 .badge.pass{color:#9ece6a}.badge.fail{color:#f7768e}
-- 
2.55.0